[MRG] replace utils.TempDirectory with run tmp #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehouts
changed the title
hehouts
changed the title
|
your PR is looking good, @hehouts ! I think you're probably interested in |
Codecov Report
@@ Coverage Diff @@
## latest #1502 +/- ##
==========================================
+ Coverage 90.25% 95.27% +5.02%
==========================================
Files 126 99 -27
Lines 21109 17405 -3704
Branches 1589 1589
==========================================
- Hits 19051 16583 -2468
+ Misses 1829 593 -1236
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
looking good! |
hehouts
changed the title
|
@ctb @bluegenes please review :) The test print statements havent changed, so Im pretty sure theyre still working |
|
@hehouts when it passes all the tests (I updated from latest again), please go ahead and merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to
runtmpintest_cmd_signature.py(1 test) andtest_index.py(3 tests)Chips away at #1386